Re: [RFC PATCH] Tracepoint: introduce tracepoint() API

From: Steven Rostedt
Date: Thu Nov 17 2011 - 17:27:21 EST


On Thu, 2011-11-17 at 16:58 -0500, Jason Baron wrote:

> I brought this issue up a while back, with a very similar patch to what
> Mathieu wrote. Please see:
>
> http://thread.gmane.org/gmane.linux.kernel/838911

Ah, I remember this now. Mathieu's version is a bit nicer. And we should
only do this for those places that are the problem cases. Basically only
the places that dereference structures, or have other indirections.

>
> One conclusion from that thread was that it would be nice if gcc could
> optimize the load so that it only happens in the unlikely path. I filed
> a gcc bug for that: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40207,
> but it doesn't seem to be implemented yet...

I agree that this is a compiler issue, but this has been two years and
no progress. Lets go with Mathieu's solution, and we should add a Link:
tag to Jason's patches as well, with a side note that talks about
Jason's previous changes with it.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/