RE: [PATCH] scsi_dh_rdac: Fix error path

[Moger, Babu]

Looks good to me..

> -----Original Message-----
> From: Richard Weinberger [mailto:richard@xxxxxx]
> Sent: Thursday, November 17, 2011 6:44 PM
> To: JBottomley@xxxxxxxxxxxxx
> Cc: Moger, Babu; Somasundaram.Krishnasamy@xxxxxxx; yanling.qi@xxxxxxx;
> linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Richard
> Weinberger
> Subject: [PATCH] scsi_dh_rdac: Fix error path
> 
> If create_singlethread_workqueue() failes, rdac_init should fail too.
> 
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
>  drivers/scsi/device_handler/scsi_dh_rdac.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/device_handler/scsi_dh_rdac.c
> b/drivers/scsi/device_handler/scsi_dh_rdac.c
> index 1d31279..2802394 100644
> --- a/drivers/scsi/device_handler/scsi_dh_rdac.c
> +++ b/drivers/scsi/device_handler/scsi_dh_rdac.c
> @@ -934,6 +934,8 @@ static int __init rdac_init(void)
>  	if (!kmpath_rdacd) {
>  		scsi_unregister_device_handler(&rdac_dh);
>  		printk(KERN_ERR "kmpath_rdacd creation failed.\n");
> +
> +		r = -EINVAL;
>  	}
>  done:
>  	return r;
> --
> 1.7.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/