Re: user namespace: make signal.c respect user namespaces (v5)

From: Eric W. Biederman
Date: Fri Nov 18 2011 - 13:45:21 EST


"Serge E. Hallyn" <serge.hallyn@xxxxxxxxxxxxx> writes:

> Quoting Eric W. Biederman (ebiederm@xxxxxxxxxxxx):
>> There is a small bug here. You want to fixup q->info, not info.
>> Otherwise you might try dereferencing one of the special signals and get
>> a NULL pointer dereference.
>
> Thanks, Eric. Oddly I've not seen this happen in quite a bit of
> testing with the kernel, but you certainly must be right. I sent
> out a new patch to fix that.

You clearly have a different test case than I do.

I managed to trigger the oops within about 5 minutes of just fooling
around.

You want to say &q->info not q->info in your updated patch.

Thanks,
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/