Re: [PATCH v2] pinctrl: indicate GPIO direction on single GPIO request

From: Linus Walleij
Date: Mon Nov 21 2011 - 07:12:56 EST


On Thu, Nov 17, 2011 at 4:29 PM, Igor Grinberg <grinberg@xxxxxxxxxxxxxx> wrote:

> You haven't responded to my request for the previous version...

Sorry, probably missed it :-(

>>  static int pin_request(struct pinctrl_dev *pctldev,
>>                      int pin, const char *function,
>> -                    struct pinctrl_gpio_range *gpio_range)
>> +                    struct pinctrl_gpio_range *gpio_range,
>> +                    bool gpio_direction)
>
> can this (and other instances) be:
> s/gpio_direction/gpio_direction_out/

Yes I realized this morning that this is a better solution.
Will post some v3 ASAP.

Thanks,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/