Re: [PATCH v3] PM/Memory-hotplug: Avoid task freezing failures

[Srivatsa S. Bhat]

On 11/21/2011 10:10 PM, Tejun Heo wrote:
> Hello, Srivatsa.
> 
> On Mon, Nov 21, 2011 at 10:06:39AM +0530, Srivatsa S. Bhat wrote:
>> void lock_system_sleep(void)
>> {
>> 	/* simplified freezer_do_not_count() */
>> 	current->flags |= PF_FREEZER_SKIP;
>>
>> 	mutex_lock(&pm_mutex);
>>
>> }
>>
>> void unlock_system_sleep(void)
>> {
>> 	mutex_unlock(&pm_mutex);
>>
>> 	/* simplified freezer_count() */
>> 	current->flags &= ~PF_FREEZER_SKIP;
>>
>> }
>>
>> We probably don't want the restriction that freezer_do_not_count() and
>> freezer_count() work only for userspace tasks. So I have open coded
>> the relevant parts of those functions here.
>>
>> I haven't tested this solution yet. Let me know if this solution looks
>> good and I'll send it out as a patch after testing and analyzing some
>> corner cases, if any.

I tested this, and it works great! I'll send the patch in some time.

> 
> Ooh ooh, I definitely like this one much better. 

Thanks :-) Even I like it far better than all those ugly hacks I proposed
earlier ;-)

> Oleg did something
> similar w/ wait_event_freezekillable() too.  On related notes,
> 
> * I think it would be better to remove direct access to pm_mutex and
>   use [un]lock_system_sleep() universally.  I don't think hinging it
>   on CONFIG_HIBERNATE_CALLBACKS buys us anything.
> 

Which direct access to pm_mutex are you referring to?
Other than suspend/hibernation call paths, I think mem-hotplug is the only
subsystem trying to access pm_mutex. I haven't checked thoroughly though. 

But yes, using lock_system_sleep() for mutually excluding some code path
from suspend/hibernation is good, and that is one reason why I wanted
to fix this API ASAP. But as long as memory hotplug is the only direct user
of pm_mutex, is it justified to remove the CONFIG_HIBERNATE_CALLBACKS
restriction and make it generic? I don't know...

Or, are you saying that we should use these APIs even in suspend/hibernate
call paths? That's not such a bad idea either...

[ On a totally different note, I was wondering:- if mem-hotplug wants to
exclude itself from hibernation alone, CONFIG_HIBERNATE_CALLBACKS is not
the right way to do it, because, it would still unintentionally exclude
itself from suspend also! (if suspend and hibernation are both enabled).
I don't think we should worry about this too much, because we don't get
much benefit trying to make mem-hotplug co-exist with suspend.. In fact,
I would say, its even better to let it be this way and exclude suspend
as well, since running exotic stuff like memory hotplug during suspend
or hibernation is best avoided ;-) ]

> * In the longer term, we should be able to toggle PF_NOFREEZE instead
>   as SKIP doesn't mean anything different.  We'll probably need a
>   better API tho.  But for now SKIP should work fine.
> 

Yep, I agree.

Thanks,
Srivatsa S. Bhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/