Re: [PATCH 0/4] Provide cpuacct functionality in cpu cgroup

[Glauber Costa]

On 11/15/2011 10:57 PM, KAMEZAWA Hiroyuki wrote:
> On Tue, 15 Nov 2011 13:59:13 -0200
> Glauber Costa<glommer@xxxxxxxxxxxxx>  wrote:
>
> > Hi,
> >
> > This is an excerpt of the last patches I sent regarding cpu cgroup.
> > It is mostly focused on cleaning up what we have now, so it can
> > be considered largely preparation. As a user of the new organization
> > of things, I am including cpuacct stats functionality in the end of
> > the series. The files related to cpuusage are left to be sent in
> > an upcoming series after this one is included.
> >
> > Let me know if there is anything you'd like me to address.
>
> I'm sorry but let me several questions.
>
> Why cpu cgroup but cpuacct cgroup ?
> If scheduler stat is reported via cpu cgroup, it makes sense.
> If user accounting information is reported via cpu cgroup, I feel it's strange.
> Do you want to make cpuacct cgroup obsolete and merge 2 cgroups ?
>
> What's relationship between this new counters and cpuacct cgroup ?
> Aren't users confused ?
>
> Please provide Documenation.

Hi Kame,

Just so you know, I intend to withdraw this. This idea came from a 
discussion with Peter, where we were thinking about ways to avoid 
collecting statistics more than once, and walking structures more than 
once as well (And cpuusage, for instance, was already collected for the 
task_groups in the scheduler).

Now, Balbir pointed out that the use case for this really needs to keep
the statistics orthogonal to scheduler entities. So with that in mind, 
merging them would complicate things more than it would simplify.

I think I can go back to my original version, where /proc/stat data is 
shown according to data collected in cpuacct.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/