Re: [PATCH] dmaengine/dw_dmac: Reconfigure interrupt and chan_cfgregister on resume

[Vinod Koul]

On Wed, 2011-11-23 at 16:41 +0530, Viresh Kumar wrote:
> On 11/23/2011 4:19 PM, Vinod Koul wrote:
> > then why not perform save and restore in your suspend and restore
> > callbacks. That way you don't pay penalty of doing that in every alloc
> > as you seem to be doing now?
> 
> Not actually. I am not saving anything to be restored after suspend.
> There are few things (configuring CFG regs and enabling interrupts),
> which are done earlier on alloc_channels. As this will not be called after
> resume, so we need to set them again.
> 
> What i have done is, removed all this stuff from alloc channels and moved it
> to dwc_dostart(). Here, i am checking if channel is already programmed or not.
> If not (Can happen only in two cases: On resume and other on fresh channel alloc),
> i configure them. So there is no save/restore actually done.
> 

okay, why were you writing to registers in alloc in the first place :)
it should have been in the dostart.

Okay now i get it, looks fine to me, I will apply it


-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/