Re: [patch 8/8] mm: memcg: modify PageCgroupCache non-atomically

[KAMEZAWA Hiroyuki]

On Wed, 23 Nov 2011 16:42:31 +0100
Johannes Weiner <hannes@xxxxxxxxxxx> wrote:

> From: Johannes Weiner <jweiner@xxxxxxxxxx>
> 
> This bit is protected by lock_page_cgroup(), there is no need for
> locked operations when setting and clearing it.
> 
> Signed-off-by: Johannes Weiner <jweiner@xxxxxxxxxx>

Hm. non-atomic ops for pc->flags seems dangerous.
How about try to remove PCG_CACHE ? Maybe we can depends on PageAnon(page).
We see 'page' on memcg->lru now.
I'm sorry I forgot why we needed PCG_CACHE flag..

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/