Re: [PATCH 1/3] usb: udc: Fix gadget driver's speed check in variousUDC drivers

From: Felipe Balbi
Date: Thu Nov 24 2011 - 04:46:58 EST


On Sat, Nov 19, 2011 at 06:26:25PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@xxxxxxxxxx>
>
> Several UDC drivers had a gadget driver's speed sanity check of the
> form of:
>
> driver->speed != USB_SPEED_HIGH
>
> or:
>
> driver->speed != USB_SPEED_HIGH && driver->speed != USB_SPEED_FULL
>
> As more and more gadget drivers support USB SuperSpeed, driver->speed
> may be set to USB_SPEED_SUPER and UDC driver should handle such gadget
> correctly. The above checks however fail to recognise USB_SPEED_SUPER
> as a valid speed.
>
> This commit changes the two checks to:
>
> driver->speed < USB_SPEED_HIGH
>
> or:
>
> driver->speed < USB_SPEED_FULL
>
> respectively.
>
> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> Reported-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

applied, thanks

--
balbi

Attachment: signature.asc
Description: Digital signature