Re: [PATCH 2/8] firmware: Sigma: Skip header during CRC generation

From: Mike Frysinger
Date: Thu Nov 24 2011 - 12:21:49 EST


On Thursday 24 November 2011 07:48:21 Lars-Peter Clausen wrote:
> The firmware header is not part of the CRC, so skip it. Otherwise the
> firmware will be rejected due to non-matching CRCs.

that's because you didn't compare to the right value ;). include the CRC ->
compare to 0. omit the CRC -> compare to the CRC value.

including the CRC and doing a compare to 0 would probably make for slightly
smaller code ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.