Re: [lm-sensors] [PATCH] hwmon: convert drivers/hwmon/* to usemodule_i2c_driver()

From: Guenter Roeck
Date: Sun Nov 27 2011 - 12:34:30 EST


On Fri, Nov 25, 2011 at 11:57:08AM -0500, Guenter Roeck wrote:
> On Fri, Nov 25, 2011 at 02:06:27AM -0500, Axel Lin wrote:
> > This patch converts the drivers in drivers/hwmon/* to use the
> > module_i2c_driver() macro which makes the code smaller and a bit
> > simpler.
> >
> > Cc: Corentin Labbe <corentin.labbe@xxxxxxxxxxx>
> > Cc: Dirk Eibach <eibach@xxxxxxxx>
> > Cc: "Mark M. Hoffman" <mhoffman@xxxxxxxxxxxxx>
> > Cc: Steve Glendinning <steve.glendinning@xxxxxxxx>
> > Cc: Riku Voipio <riku.voipio@xxxxxx>
> > Cc: Guillaume Ligneul <guillaume.ligneul@xxxxxxxxx>
> > Cc: David George <david.george@xxxxxxxxx>
> > Cc: "Hans J. Koch" <hjk@xxxxxxxxxxxx>
> > Cc: Marc Hulsman <m.hulsman@xxxxxxxxxx>
> > Cc: Rudolf Marek <r.marek@xxxxxxxxxxxx>
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
>
> Acked-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx>
>
> What is the plan for those patches ? Are they expected to all go through the same tree,
> or through individual trees after the necessary defines are introduced into mainline ?
>
My question was answered in another thread related to the misc subsystem.
The patch this one depends on will only be available in 3.3-rc1. It would have been
nice to let us know ahead of time, because I _did_ find out the hard way.

I would suggest to resubmit the i2c and spi patches against a working baseline
once it is available, to make sure it does not miss some new drivers.

On a side note, this patch does miss the drivers in hwmon/pmbus, but I can take care
of those myself.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/