Re: [PATCH 01/62] highmem: mark k[un]map_atomic() with two argumentsas deprecated

From: Cong Wang
Date: Mon Nov 28 2011 - 00:08:04 EST


ä 2011å11æ27æ 20:34, Cesar Eduardo Barros åé:

This will break the misuse detection of kunmap_atomic (see commit 597781f3e51f48ef8e67be772196d9e9673752c4).

kunmap_atomic() _must_ be a macro, so the __same_type can see the type the caller used. If you use an inline function, all it will see is a void *, even if the caller confused it with kunmap() and passed a struct page *.


Hmm, I think you are right, I will switch it back to a macro.

Thanks for review!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/