RE: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042fuel gauge

From: Pallala, Ramakrishna
Date: Mon Nov 28 2011 - 01:01:32 EST




> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@xxxxxxxxx]
> Sent: Saturday, November 26, 2011 5:46 AM
> To: Pallala, Ramakrishna
> Cc: myungjoo.ham@xxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dwmw2@xxxxxxxxxxxxx; ïÚïïï;
> Wolfram Sang; R, Durgadoss
> Subject: Re: [PATCHv1 1/1] [Power Supply]: Fix error handling in max17042 fuel gauge
>
> On Wed, Sep 07, 2011 at 02:00:29PM +0530, Pallala, Ramakrishna wrote:
> > > > In max17042_get_property(...), the values returned by
> > > > max17042_read_reg are directly assigned to the variables,
> > > > even if the read results in an error.
> > > >
> > > > This patch checks for the return code from max17042_read_reg and
> > > > exits the function if there is any error.
> > > >
> > > > Signed-off-by: Ramakrishna Pallala
> > > > ---
> > > > drivers/power/max17042_battery.c | 85 ++++++++++++++++++++++++++------------
> > > > 1 files changed, 58 insertions(+), 27 deletions(-)
> > > >
> > >
> > > Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> >
> > Thanks for the Ack.
> > When can I expect the patch to be merged ?
>
> Merged, much thanks!
>
> Note that I had to manually fix conflicts with
>
> commit cf7a8c03db792894f436db5f3ffc44d947b9b068
> Author: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
> Date: Wed Aug 17 10:18:34 2011 +0900
>
> max17042_battery: Bugfix of incorrect voltage register value interpretation
>
>
> So, the resulting patch in battery-2.6.git tree as follows, please
> check if everything is OK:

The patch looks good.
Thanks for resolving the conflicts :)

Thanks,
Ram
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i