Re: [PATCH v5] power: bq20z75: devicetree init support

[Rhyland Klein]

On Thu, 2011-11-24 at 10:42 -0800, Anton Vorontsov wrote:
> Hello Rhyland,
> 
> Got this:
> 
>   CC [M]  drivers/power/bq20z75.o
> drivers/power/bq20z75.c: In function âbq20z75_of_populate_pdataâ:
> drivers/power/bq20z75.c:630:21: error: storage size of âgpio_flagsâ isnât known
> drivers/power/bq20z75.c:668:2: error: implicit declaration of function âof_get_named_gpio_flagsâ [-Werror=implicit-function-declaration]
> drivers/power/bq20z75.c:671:19: error: âOF_GPIO_ACTIVE_LOWâ undeclared (first use in this function)
> drivers/power/bq20z75.c:671:19: note: each undeclared identifier is reported only once for each function it appears in
> drivers/power/bq20z75.c:630:21: warning: unused variable âgpio_flagsâ [-Wunused-variable]
> drivers/power/bq20z75.c:627:29: warning: unused variable âdtidâ [-Wunused-variable]
> 
> I fixed this by...
> 
> On Wed, Sep 14, 2011 at 01:19:07PM -0700, Rhyland Klein wrote:
> 
> > +#if defined(CONFIG_OF)
> > +#include <linux/of_device.h>
> 
> Adding linux/of_gpio.h
> 
> > +static const struct of_device_id bq20z75_dt_ids[] = {
> > +	{ .compatible = "ti,bq20z75" },
> > +	{ }
> > +};
> > +MODULE_DEVICE_TABLE(i2c, bq20z75_dt_ids);
> > +
> > +static struct bq20z75_platform_data *bq20z75_of_populate_pdata(
> > +	struct i2c_client *client)
> > +{
> > +	const struct of_device_id *dtid;
> 
> And deleting that line.
> 
> 
> Applied to battery-2.6.git, but please double check if everything
> is OK.
> 
> Thanks,
> 

Yah, sorry about that. Seems things have changed a bit since I
originally sent out the patch. I synced battery-2.6 and everything looks
great.

thanks,
rhyland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/