Re: XFS read hangs in 3.1-rc10

From: Ben Myers
Date: Mon Nov 28 2011 - 16:00:59 EST


Hey Christoph,

On Mon, Nov 28, 2011 at 02:55:05PM -0500, Christoph Hellwig wrote:
> On Mon, Nov 28, 2011 at 11:05:54AM -0800, Simon Kirby wrote:
> > On Sun, Nov 20, 2011 at 10:32:41AM -0500, Christoph Hellwig wrote:
> >
> > > On Wed, Nov 16, 2011 at 11:56:43AM -0800, Simon Kirby wrote:
> > > > Sorry for the delay in testing.
> > > >
> > > > Yes, everything looks fine even with the xfs_log_force line from your
> > > > patch commented out. So, the changes in xfs_reclaim_inode() are just the
> > > > set_bit(XBT_FORCE_FLUSH) and wake_up_process(), relative to 3.1.
> > >
> > > Dave pointed out that we can do better than the big hammer, and the
> > > patch below should fix your issue, too. Can you test it?
> >
> > Yes, seems to be fine. No hung task warnings, tested for ~5 days.
>
> Thanks a lot for the testing Simon.
>
> Ben, can you add a:
>
> Tested-by: Simon Kirby <sim@xxxxxxxxxx>
>
> to the patch when applying it?

Yep, I will add Simon's Tested-by:

Thanks Simon! ;)

-Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/