Re: [PATCH 2/2] misc: add driver support for MAX8997 MUIC

From: Kyungmin Park
Date: Mon Nov 28 2011 - 19:02:31 EST


On 11/29/11, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 24 Nov 2011 18:12:18 +0900
> Donggeun Kim <dg77.kim@xxxxxxxxxxx> wrote:
>
>> The MUIC function in MAX8997 device can be used as
>> a USB port detector and switch.
>> This patch supports the MUIC feature of MAX8997.
>>
>> Signed-off-by: Donggeun Kim <dg77.kim@xxxxxxxxxxx>
>> Signed-off-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>
> Samuel, can you please merge this if/when it's ready?

Thank you!

FYI: Now we proposed the new subsystem to handle the external
connector, "multistate switch'.
and this drivers is the candidate one for this subsystem.
Previous time, we sent the fsa9480, micro USB switch. this driver is
also covered at multistate switch framework.

Thank you,
Kyungmin Park
>
>>
>> ...
>>
>> +static irqreturn_t max8997_muic_irq_handler(int irq, void *data)
>> +{
>> + struct max8997_muic_info *info = data;
>> +
>> + dev_dbg(info->dev, "irq:%d\n", irq);
>> + info->irq = irq;
>> +
>> + schedule_work(&info->irq_work);
>> +
>> + return IRQ_HANDLED;
>> +}
>
> The code does schedule_work() but I see no flush_work(). Is it
> possible for the work to still be pending after device shutdown, or
> even after rmmod?
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/