Re: [PATCH 2/2] drm/i915: properly clflush pwrites to phys objects

From: Chris Wilson
Date: Tue Nov 29 2011 - 10:36:15 EST


On Tue, 29 Nov 2011 16:09:29 +0100, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> Usually results in (rare) cursor corruptions on platforms
> requiring physically addressed cursors.

So the phys cursor pages are set to WC upon creation, are we just
missing the mb()? Or more likely the CPUs don't have PAT and we are
being lazy in not detecting the error.

Anyway as this is reported to fix the issue on 8xx at least, overkill
is fine. :)

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/