Re: [PATCH-RFC 1/2] tile: don't panic on iomap

From: Arnd Bergmann
Date: Tue Nov 29 2011 - 17:05:33 EST


On Tuesday 29 November 2011, Michael S. Tsirkin wrote:
> diff --git a/arch/tile/include/asm/io.h b/arch/tile/include/asm/io.h
> index c9ea165..be6090d 100644
> --- a/arch/tile/include/asm/io.h
> +++ b/arch/tile/include/asm/io.h
> @@ -204,7 +204,8 @@ static inline long ioport_panic(void)
>
> static inline void __iomem *ioport_map(unsigned long port, unsigned int len)
> {
> - return (void __iomem *) ioport_panic();
> + pr_info("Trying to map an IO resource - it does not exit on tile.\n");
> + return NULL;
> }

Why not just set CONFIG_NO_IOPORT and make this unavailable at compile time?

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/