Re: [RGC PATCH 0/2] split file2alias using elf sections

From: Alessandro Rubini
Date: Wed Nov 30 2011 - 19:53:58 EST


Hello Rusty, thankyou for your feedback.
I plan to make V2 tomorrow (it was planned much earlier).

> The table driven loop is nice and simple, though the E() macro is a bit
> contrived.

Yes, but we have long names and I wanted to avoid splitting lines.
I can make it ENTRY().

> The separation into separate files just to avoid merge issues is
> overkill and useless churn. The conflicts are simple, and you've just
> moved themto conflicts in the Makefile.

Yes and no. Actually, I expect several new buses to appear over time,
and being separate files they can even be conditionally compiled based
on config.

> We'd be better off putting the table in alphabetical order and stopping
> there. Easy code, no tricks.

I see. I'm submitting two patches anyways, but you can pick one only.

Thanks
/alessandro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/