Re: [PATCH] net/macb: add DT support

From: Nicolas Ferre
Date: Mon Dec 05 2011 - 06:51:44 EST


On 12/05/2011 12:48 PM, Jamie Iles :
On Fri, Dec 02, 2011 at 06:53:58PM +0100, Nicolas Ferre wrote:
On 12/02/2011 06:28 PM, Jamie Iles :
[...]
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 103c6e6..89060e6 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -1247,6 +1247,8 @@ static const struct of_device_id macb_dt_ids[] = {
{ .compatible = "cdns,at32ap7000-macb" },
{ .compatible = "cdns,at91sam9260-macb" },
{ .compatible = "cdns,macb" },
+ { .compatible = "cdns,pc302-gem" },
+ { .compatible = "cdns,gem" },
{ /* sentinel */ }
};

BTW, I think we may also modify the MII/RMII selection code for
adding gigabit selection... but maybe you already have the patches?

No, I don't have access to a version of the GEM with gigabit support.
The platforms I was working on used it as a 10/100 controller, but had
to use the GEM to get hardware timestamping support.

Ok, Thanks for your feedback. I send a v3 patch now.

Best regards,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/