Re: [PATCH 1/3] PM / Sleep: Make [un]lock_system_sleep() generic

From: Srivatsa S. Bhat
Date: Mon Dec 05 2011 - 14:19:13 EST


Hi Oleg,

On 12/06/2011 12:05 AM, Oleg Nesterov wrote:

> On 12/05, Srivatsa S. Bhat wrote:
>>
>> I looked up in git and found that commit ba96a0c by Rafael introduced the
>> count functions, to handle the vfork case. But now, we seem to have more
>> uses than that. So I think we can remove that userspace restriction in the
>> count functions,
>
> Agreed.
>
>> and in kernel/fork.c, do something like:
>>
>> if (current->mm)
>> freezer_do_not_count();
>> ...
>> if (current->mm)
>> freezer_count();
>
> see http://marc.info/?l=linux-kernel&m=132033335507261
>
> I think this is not needed, we can just remove the ->mm check.
> CLONE_VFORK is not used by a freezable kthread.
>


Great! Thanks for the pointer. I'll send a patch to remove that check.

Regards,
Srivatsa S. Bhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/