Re: [tip:core/locking] lockdep, rtmutex, bug: Show taint flags onerror

[Ingo Molnar]

* Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:

> > What Peter did was rather sensible: he split a patch that 
> > did two things into two and applied one standalone, 
> > uncontroversial half of it and kept the part of the part of 
> > the changelog that related to that change.
> [...]
> 
> I can accept that if the change from my submission is 
> commented in the commit message.  (I sometimes do that with 
> other people's patches.)  But this was modified without 
> comment.

That was not what you requested though:

> > > > > If you disagree with a patch, do not silently drop 
> > > > > parts of it.  I demand that you remove my 
> > > > > 'Signed-off-by' as this is not the change I submitted.

What happened is that you did two things in a single patch and 
Peter applied the uncontroversial, unrelated bits in full.

> Giving credit for authorship is important, but it is also 
> important not to say someone is the sole author of something 
> when they aren't and haven't approved the subsequent changes 
> (cf. Alan Smithee).

It's all hunks submitted by you, you are the only author.

He did not modify your changes - you submitted several changes. 

You are actually the sole author of those changes in the commit. 
Peter only split up your original patch - he was actually being 
very constructive and 100% helpful with upstreaming your debug 
printout changes - which makes your original objection doubly 
offensive.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/