Re: [PATCH] KVM: Document KVM_NMI

[Avi Kivity]

On 12/06/2011 10:50 PM, Sasha Levin wrote:
> Cc: Avi Kivity <avi@xxxxxxxxxx>
> Cc: Marcelo Tosatti <mtosatti@xxxxxxxxxx>
> Cc: kvm@xxxxxxxxxxxxxxx

Somehow, the changelog became the place where people manage their cc lists.

>  
> +4.64 KVM_NMI
> +
> +Capability: basic
> +Architectures: none
> +Type: vcpu ioctl
> +Parameters: none
> +Returns: 0 on success, -1 on error
> +
> +Trigger an NMI on the specified VCPU.
> +
> +This can be used to cause a panic in the guest, which in turn would result
> +in a backtrace/dump.
> +

I'm nitpicking, but this is too strongly worded.  It's completely up to
the guest how to interpret the NMI.

It's also subtly broken with kernel irqchip - it injects an NMI
unconditionally even though LINT1 can be configured to mask NMIs, or to
do something other than queue an NMI (for example, queue a regular
interrupt).  Please note this.

On second thoughts, I'll just document this instead of telling you what
to write.

-- 
error compiling committee.c: too many arguments to function
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/