Re: [PATCH 1/2] xen/granttable: Support sub-page grants

From: ANNIE LI
Date: Wed Dec 07 2011 - 05:28:00 EST




On 2011-12-7 17:57, Ian Campbell wrote:
On Wed, 2011-12-07 at 08:59 +0000, Paul Durrant wrote:
gnttab_v2_ops = {
...
.access_subpage = access_subpage_v2;
.access_ref_subpage = access_ref_subpage_v2; .access_trans =
access_trans_v2; .access_ref_trans = access_ref_trans_v2; }


Do you need ops for the ref and non-ref functions? I would have
thought you could just have the ref ones since the all the non-ref
variants do is allocate and then call the ref variant.
Good point. It appears that all the existing ops are only present in the
ref form.
So I will add two elements: access_ref_subpage and access_ref_trans into gnttab_v2_ops.

Thanks
Annie
Ian.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/