Re: [patch v3 5/6] sched, ttwu_queue: queue remote wakeups onlywhen crossing cache domains

[Suresh Siddha]

On Wed, 2011-12-07 at 08:23 -0800, Peter Zijlstra wrote:
> In fact, Ingo (rightfully) refused to take this due to the x86 specific
> code in scheduler guts..

I noticed this while reviewing/testing the patch and left it because on
the microbenchmark, it had measurable impact of using the direct check
as compared to going through the scheduler domains every time to figure
out if we shared the LLC or not.

> Initially the idea was to provide a new arch interface and a fallback
> and do the Kconfig thing etc. After a bit of thought I decided against
> that for we already have that information in the sched_domain tree
> anyway and it should be a simple matter of representing things
> differently.

This def looks better.

> +DEFINE_PER_CPU(int, sd_top_spr_id);

pkg_srid (shared resource id)?

> +
> +static void update_top_cache_domain(int cpu)
> +{
> +	struct sched_domain *sd;
> +	int id = -1;
> +
> +	sd = highest_flag_domain(cpu, SD_SHARE_PKG_RESOURCES);
> +	if (sd)
> +		id = cpumask_first(sched_domain_span(sd));

if there is no sd with shared pkg resources, then id has to be set to
'cpu'.

> +	rcu_assign_pointer(per_cpu(sd_top_spr, cpu), sd);
> +	per_cpu(sd_top_spr_id, cpu) = id;

Otherwise it looks good.

Acked-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/