Re: [PATCH] HID: wiimote: Select INPUT_FF_MEMLESS

[simon]

> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index edf2b2b..dae04a0 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -591,6 +591,7 @@ config HID_WIIMOTE
>  	depends on BT_HIDP
>  	depends on LEDS_CLASS
>  	select POWER_SUPPLY
> +	select INPUT_FF_MEMLESS
>  	---help---
>  	Support for the Nintendo Wii Remote bluetooth device.

I don't mean to be a complainer, but shouldn't the WiiMote module depend
on FF_MEMLESS rather than just forcing it on.

The module could also #define the appropriate bits so that FF_MEMLESS was
only used when available, the rumble motor is a very small part of the
WiiMote's feature set.

Some people might not want FF_MEMLESS enabled.
Simon.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/