Re: [PATCH 2/2] x86, MCE: Drain mcelog buffer

From: Borislav Petkov
Date: Fri Dec 09 2011 - 13:24:54 EST


On Fri, Dec 09, 2011 at 10:19:02AM -0800, Luck, Tony wrote:
> void mce_register_decode_chain(struct notifier_block *nb)
> {
> atomic_notifier_chain_register(&x86_mce_decoder_chain, nb);
> + drain_mcelog_buffer();
> }
>
> Won't this dump all the pended stuff to the *first* guy to
> register - but subsequent interested parties will still
> miss out?

Yeah,

this is currently assuming that we have one consumer per system. At
least this is the case on AMD: MCE decoder registers and decodes the
errors. It will pass a subset of the MCEs (DRAM ECCs) to amd64_edac for
additional massaging.

Do you see a usecase for multiple consumers?

--
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/