Re: [PATCH 3/3] kref: Remove the memory barriers

From: Peter Zijlstra
Date: Sun Dec 11 2011 - 10:36:30 EST


On Sun, 2011-12-11 at 20:59 +0800, Ming Lei wrote:
>
> The implicit rule about kref is that use should make sure
> that kref can not be touched once it is released.

The only transition for with order makes any difference what so ever is
1 -> 0, you just said that should be done by external means (I agree and
have argued thusly), therefore any memory barriers outside of these
external means are superfluous.

Thus the proposed patch is correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/