Re: [PATCH 2/2] acerhdf: Message logging neatening

From: Joe Perches
Date: Mon Dec 12 2011 - 13:56:37 EST


On Mon, 2011-12-12 at 19:26 +0100, Peter Feuerer wrote:
> > @@ -605,8 +603,8 @@ static int acerhdf_check_hardware(void)
> > }
> >
> > if (!bios_cfg) {
> > - pr_err("unknown (unsupported) BIOS version %s/%s/%s, "
> > - "please report, aborting!\n", vendor, product, version);
> > + pr_err("unknown (unsupported) BIOS version %s/%s/%s, please report, aborting!\n",
> > + vendor, product, version);
>
> disagree, as it exceeds 80 chars.

Format strings should be coalesced.
checkpatch ignores these long lines.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/