Re: [PATCH RESEND 1/2] MFD: MAX8997: add platform data and devicesfor LED control

From: Samuel Ortiz
Date: Tue Dec 13 2011 - 15:54:17 EST


Hi Donggeun,

On Tue, Dec 13, 2011 at 05:13:52PM +0900, Donggeun Kim wrote:
> diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
> index 5be53ae..cb83a7a 100644
> --- a/drivers/mfd/max8997.c
> +++ b/drivers/mfd/max8997.c
> @@ -43,7 +43,8 @@ static struct mfd_cell max8997_devs[] = {
> { .name = "max8997-battery", },
> { .name = "max8997-haptic", },
> { .name = "max8997-muic", },
> - { .name = "max8997-flash", },
That doesn't seem to be related to this patch.


> + { .name = "max8997-led", .id = 1 },
> + { .name = "max8997-led", .id = 2 },
> };
> @@ -172,7 +194,8 @@ struct max8997_platform_data {
>
> /* HAPTIC: Not implemented */
> /* RTC: Not implemented */
> - /* Flash: Not implemented */
> + /* ---- Flash ---- */
> + struct max8997_led_platform_data *led_pdata;
This is a bit confusing: Flash and LED ?

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/