Re: [PATCH] asus-wmi: explicitly set the wireless LED

[Corentin Chary]

On Wed, Dec 7, 2011 at 9:02 AM, Keng-Yu Lin <kengyu@xxxxxxxxxxxxx> wrote:
> On Asus K54C, the wireless LED is always off without setting explicitly.
>
> Signed-off-by: Keng-Yu Lin <kengyu@xxxxxxxxxxxxx>
> ---
> Âdrivers/platform/x86/asus-wmi.c | Â Â3 +++
> Â1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
> index d1049ee..db514c4 100644
> --- a/drivers/platform/x86/asus-wmi.c
> +++ b/drivers/platform/x86/asus-wmi.c
> @@ -726,6 +726,9 @@ static int asus_rfkill_set(void *data, bool blocked)
> Â Â Â Âstruct asus_rfkill *priv = data;
> Â Â Â Âu32 ctrl_param = !blocked;
>
> + Â Â Â if (priv->dev_id == ASUS_WMI_DEVID_WLAN)
> + Â Â Â Â Â Â Â asus_wmi_set_devstate(ASUS_WMI_DEVID_WIRELESS_LED, ctrl_param, NULL);
> +
> Â Â Â Âreturn asus_wmi_set_devstate(priv->dev_id, ctrl_param, NULL);
> Â}
>
> --
> 1.7.5.4
>

NACK

If this is only for K54C (works fine on my G73 anyway) then you must
do some kind of DMI matching right ? Or at least check that this led
is present. Do you have any list of laptops that export this LED and
how it behave ?

Anyway, you should use a led trigger for that, ideally the rfkill%d
led trigger, but for that you need the rfkill idx, which is not
exported, so you may need a new rfkill_idx() function. CCing rfkill
and led guys, they may have a better advice on that.
-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/