Re: [PATCH] Put braces around potentially empty 'if' body inhandle_pte_fault()

[Eric Dumazet]

Le dimanche 18 dÃcembre 2011 Ã 01:03 +0100, Jesper Juhl a Ãcrit :
> If one builds the kernel with -Wempty-body one gets this warning:
> 
>   mm/memory.c:3432:46: warning: suggest braces around empty body in an âifâ statement [-Wempty-body]
> 
> due to the fact that 'flush_tlb_fix_spurious_fault' is a macro that
> can sometimes be defined to nothing.
> 
> I suggest we heed gcc's advice and put a pair of braces on that if.
> 
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
> ---
>  mm/memory.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 829d437..9cf1b48 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3428,9 +3428,9 @@ int handle_pte_fault(struct mm_struct *mm,
>  		 * This still avoids useless tlb flushes for .text page faults
>  		 * with threads.
>  		 */
> -		if (flags & FAULT_FLAG_WRITE)
> +		if (flags & FAULT_FLAG_WRITE) {
>  			flush_tlb_fix_spurious_fault(vma, address);
> +		}
>  	}
>  unlock:
>  	pte_unmap_unlock(pte, ptl);
> -- 
> 1.7.8
> 

Thats should be fixed in the reverse way :

#define flush_tlb_fix_spurious_fault(vma, address) do { } while (0)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/