Re: [PATCH 14/15] module_param: make bool parameters really bool(net & drivers/net)

From: Joe Perches
Date: Mon Dec 19 2011 - 01:43:03 EST


On Mon, 2011-12-19 at 16:19 +1030, Rusty Russell wrote:
> diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h
[]
> @@ -808,8 +808,8 @@ typedef enum {
[]
> +static bool coalesce[MAX_UNITS] = {1,1,1,1,1,1,1,1};
> +static bool dynamic_ipg[MAX_UNITS] = {0,0,0,0,0,0,0,0};

Perhaps these array initializations could/should be:

static bool coalesce[MAX_UNITS] = { [0 ... MAX_UNITS - 1] = true };
static bool dynamic_irq[MAX_UNITS] = { [0 ... MAX_UNITS - 1] = false };

in a separate patch maybe.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/