Re: [PATCH v4 3/4] regulator: simplify twl4030 config

[Mark Brown]

On Tue, Dec 20, 2011 at 03:36:59AM +0200, Felipe Contreras wrote:
> On Tue, Dec 20, 2011 at 3:19 AM, Mark Brown

> > No, this is the wrong way to go about this - why are you making this
> > change for this one driver only?

> Because that's the only one I care about. I can try to do the same for
> all the others if you wish.

Yes, of course.  Half the point in having subsystems and standard ways
of doing things is so that when we look at things we've got a reasonable
idea as to what they're supposed to be doing and people looking at the
code can figure out what's going on.   We don't want people to have to
play guessing games about this stuff.

> > Exactly the same argument would apply
> > to all the other MFD regulators and to all the other MFD subdrivers in
> > the various subsystems.

> Yes, the ones that closely related to certain architectures or chips.

Obviously all MFDs are closely releated to chips...

> And this is already done:
> 
> REGULATOR_AB3100:
> 	depends on AB3100_CORE
> 	default y if AB3100_CORE

> (if AB3100_CORE is redundant BTW)

> REGULATOR_TPS6105X:
> 	depends on TPS6105X
> 	default y if TPS6105X

So it's done by a small proportion of drivers...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/