Re: [PATCH 1/3] perf: __perf_evlist__mmap: Fix errno value on failedmap.

From: Arnaldo Carvalho de Melo
Date: Tue Dec 20 2011 - 12:56:11 EST


Em Tue, Dec 20, 2011 at 12:33:30AM +0900, Namhyung Kim escreveu:
> > evlist->mmap[idx].base = mmap(NULL, evlist->mmap_len, prot,
> > MAP_SHARED, fd, 0);
> > - if (evlist->mmap[idx].base == MAP_FAILED)
> > + if (evlist->mmap[idx].base == MAP_FAILED) {
> > + evlist->mmap[idx].base = NULL;
> > return -1;
> > + }
> >
> > perf_evlist__add_pollfd(evlist, fd);
> > return 0;
>
> Thanks for fixing this. I posted a basically same patch for this [1]
> last week, but it seems my patch doesn't get included yet (right?),
> and your patch looks bit simpler. So Arnaldo, I'm totally fine if you
> decide to take this instead of mine.

Yeah, Nelson's seems more simple, so I'm applying his and adding your
Acked-by,

Thanks,

> Thanks.
> Namhyung Kim
>
>
> [1] https://lkml.org/lkml/2011/12/12/275
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/