Re: [PATCH RFC] virtio_net: fix refill related races

From: Michael S. Tsirkin
Date: Tue Dec 20 2011 - 14:43:28 EST


On Tue, Dec 20, 2011 at 11:31:54AM -0800, Tejun Heo wrote:
> On Tue, Dec 20, 2011 at 09:30:55PM +0200, Michael S. Tsirkin wrote:
> > Hmm, in that case it looks like a nasty race could get
> > triggered, with try_fill_recv run on multiple CPUs in parallel,
> > corrupting the linked list within the vq.
> >
> > Using the mutex as my patch did will fix that naturally, as well.
>
> Don't know the code but just use nrt wq. There's even a system one
> called system_nrq_wq.
>
> Thanks.

We can, but we need the mutex for other reasons, anyway.

> --
> tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/