Re: [PATCH 1/1][RESEND] Staging: hv: storvsc: Move the storage driverout of the staging area

From: Williams, Dan J
Date: Tue Dec 20 2011 - 20:32:38 EST


On Tue, Dec 20, 2011 at 4:42 PM, KY Srinivasan <kys@xxxxxxxxxxxxx> wrote:
>
>
>> -----Original Message-----
>> From: dan.j.williams@xxxxxxxxx [mailto:dan.j.williams@xxxxxxxxx] On Behalf Of
>> Dan Williams
>> Sent: Tuesday, December 20, 2011 6:06 PM
>> To: KY Srinivasan
>> Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>> devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; ohering@xxxxxxxx;
>> James.Bottomley@xxxxxxxxxxxxxxxxxxxxx; hch@xxxxxxxxxxxxx; linux-
>> scsi@xxxxxxxxxxxxxxx
>> Subject: Re: [PATCH 1/1][RESEND] Staging: hv: storvsc: Move the storage driver
>> out of the staging area
>>
>> On Tue, Dec 20, 2011 at 10:51 AM, K. Y. Srinivasan <kys@xxxxxxxxxxxxx> wrote:
>> > The storage driver (storvsc_drv.c) handles all block storage devices
>> > assigned to Linux guests hosted on Hyper-V. This driver has been in the
>> > staging tree for a while and this patch moves it out of the staging area.
>> > As per Greg's recommendation, this patch makes no changes to the staging/hv
>> > directory. Once the driver moves out of staging, we will cleanup the
>> > staging/hv directory.
>> >
>> > This patch includes all the patches that I have sent against the staging/hv
>> > tree to address the comments I have gotten to date on this storage driver.
>> > Greg has already applied all these patches to the staging tree.
>> >
>> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
>> > ---
>> >  drivers/scsi/Kconfig       |    7 +
>> >  drivers/scsi/Makefile      |    3 +
>> >  drivers/scsi/storvsc_drv.c | 1586
>> ++++++++++++++++++++++++++++++++++++++++++++
>> >  3 files changed, 1596 insertions(+), 0 deletions(-)
>> >  create mode 100644 drivers/scsi/storvsc_drv.c
>>
>> Shouldn't this diffstat be something like the following?
>>
>>  drivers/scsi/Kconfig                       |    7 +
>>  drivers/scsi/Makefile                      |    3 +
>>  drivers/{staging/hv => scsi}/storvsc_drv.c |  310 +++++++++++++++++++---------
>>  3 files changed, 218 insertions(+), 102 deletions(-)
>>  rename drivers/{staging/hv => scsi}/storvsc_drv.c (87%)
>
> As per Greg's suggestion, this patch does not remove the driver from
> the staging tree. Once the driver lands in the correct directory, we will
> remove the driver from the staging directory.

Ah, ok, so the patch can be accepted in parallel with the staging update.

I still think it wouldn't hurt to show what:

git diff --stat --summary -M

...is after the removal of the version in drivers/staging/hv/ to
quickly show that git agrees that the versions are indeed identical,
but no big deal.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/