Re: [PATCH] vmalloc: remove #ifdef in function body

[Michal Nazarewicz]

On Wed, 21 Dec 2011 07:32:36 +0100, Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Wed, 2011-12-21 at 07:21 +0100, Michal Nazarewicz wrote:
> > it seems the community prefers
> > having ifdefs outside of the function.
>
> Some do, some don't.
>
> http://comments.gmane.org/gmane.linux.network/214543

This patch that you pointed to is against â#ifdefs are uglyâ style
described in Documentation/SubmittingPatches.

> If it's not in coding style, I suggest
> it should be changed if it doesn't
> add some other useful value.

That my be true.  I guess no one took time to adding it to the document.

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  MichaÅ âmina86â Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/