Re: [PATCH 1/4] cgroup: remove redundant get/put of old css_set frommigrate

From: Li Zefan
Date: Thu Dec 22 2011 - 00:09:55 EST


Mandeep Singh Baines wrote:
> We can now assume that the css_set reference held by the task
> will not go away for an exiting task. PF_EXITING state can be
> trusted throughout migration by checking it after locking
> threadgroup.
>
> While at it, renamed css_set_check_fetched to css_set_fetched.
> !css_set_fetched() seems to read better than
> !css_set_check_fetched().
>
> Changes in V4:
> * https://lkml.org/lkml/2011/12/20/368 (Tejun Heo)
> * Fix typo in commit message
> * Undid the rename of css_set_check_fetched
> * https://lkml.org/lkml/2011/12/20/427 (Li Zefan)
> * Fix comment in cgroup_task_migrate()
> Changes in V3:
> * https://lkml.org/lkml/2011/12/20/255 (Frederic Weisbecker)
> * Fixed to put error in retval
> Changes in V2:
> * https://lkml.org/lkml/2011/12/19/289 (Tejun Heo)
> * Updated commit message
>
> Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxxxx>

Reviewed-by: Li Zefan <lizf@xxxxxxxxxxxxxx>

> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Li Zefan <lizf@xxxxxxxxxxxxxx>
> Cc: containers@xxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: cgroups@xxxxxxxxxxxxxxx
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Oleg Nesterov <oleg@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Paul Menage <paul@xxxxxxxxxxxxxx>
> ---
> kernel/cgroup.c | 28 ++++++++--------------------
> 1 files changed, 8 insertions(+), 20 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/