Re: [resend PATCH for 3.2] procfs: do not confuse jiffies with cputime64_t

From: Andreas Schwab
Date: Thu Dec 22 2011 - 05:18:45 EST


Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> writes:

> On Thu, 22 Dec 2011 01:14:39 +0100
> Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
>
>> > a) what effect does this problem have upon users of the kernel?
>>
>> get_idle_time returns the value in the wrong unit.
>
> So the "idle" fields in /proc/stat are wrong.
>
> We're getting there! Now, in what way are they wrong?

They use the wrong unit, off by the factor between jiffies and cputime.

> How could a kernel maintainer recognise that this patch is needed?

By running the kernel on one of the architectures that are affected (did
I already say that on most architectures jiffies and cputime are
equivalent?).

Andreas.

--
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/