Re: [PATCH v3] Regulator: Add Anatop regulator driver
From: Shawn Guo
Date: Tue Dec 27 2011 - 06:29:51 EST
On Tue, Dec 27, 2011 at 06:16:34PM +0800, Ying-Chun Liu (PaulLiu) wrote:
> From: "Ying-Chun Liu (PaulLiu)" <paul.liu@xxxxxxxxxx>
> Anatop is an integrated regulator inside i.MX6 SoC.
> There are 3 digital regulators which controls PU, CORE (ARM), and SOC.
> And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB).
> This patch adds the Anatop regulator driver.
> Signed-off-by: Nancy Chen <Nancy.Chen@xxxxxxxxxxxxx>
> Signed-off-by: Ying-Chun Liu (PaulLiu) <paul.liu@xxxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: Liam Girdwood <lrg@xxxxxx>
> drivers/regulator/Kconfig | 6 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/anatop-regulator.c | 214 ++++++++++++++++++++++++++++
> include/linux/regulator/anatop-regulator.h | 63 ++++++++
> 4 files changed, 284 insertions(+), 0 deletions(-)
> create mode 100644 drivers/regulator/anatop-regulator.c
> create mode 100644 include/linux/regulator/anatop-regulator.h
> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
> index 9713b1b..fc22b8d 100644
> --- a/drivers/regulator/Kconfig
> +++ b/drivers/regulator/Kconfig
> @@ -327,5 +327,11 @@ config REGULATOR_AAT2870
> If you have a AnalogicTech AAT2870 say Y to enable the
> regulator driver.
> +config REGULATOR_ANATOP
> + tristate "ANATOP LDO regulators"
> + depends on SOC_IMX6
There is no symbol 'SOC_IMX6'. Instead, it's 'SOC_IMX6Q'.
> +int anatop_regulator_probe(struct platform_device *pdev)
> + struct regulator_desc *rdesc;
> + struct regulator_dev *rdev;
> + struct anatop_regulator *sreg;
> + struct regulator_init_data *initdata;
> + initdata = pdev->dev.platform_data;
It seems that the driver only gets probed in non-dt way. But imx6q
only supports DT. How does this driver work on imx6q?
PS. The regulator DT binding has been available on -next, so I do not
understand why you are still getting regulator_init_data from
platform_data rather than device tree.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/