Re: [PATCH 6/6] drivers/mtd/nand/txx9ndfmc.c: usedevm_request_and_ioremap

From: Julia Lawall
Date: Tue Dec 27 2011 - 09:46:15 EST

On Tue, 27 Dec 2011, Artem Bityutskiy wrote:

On Tue, 2011-12-27 at 15:01 +0100, Julia Lawall wrote:
From: Julia Lawall <julia@xxxxxxx>

Reimplement a call to devm_request_mem_region followed by a call to ioremap
or ioremap_nocache by a call to devm_request_and_ioremap.

The semantic patch that makes this transformation is as follows:

// <smpl>
expression myname;
identifier i;

struct platform_driver i = { .driver = { .name = myname } };

expression dev,res,size;
expression nm.myname;

-if (!devm_request_mem_region(dev, res->start, size,
- \(res->name\|dev_name(dev)\|myname\))) {
- ...
- return ...;
... when != res->start
... when any
when != res->start
// </smpl>

Signed-off-by: Julia Lawall <julia@xxxxxxx>

Pushed to l2-mtd-2.6.git, thanks!

I think this semantic patch is also useful and deserves to be added to
scripts/coccinelle. In general, it would be great if you sumbitted
useful spatches there for inclusion.

OK, I will add this one as well.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at