Re: [PATCH] cgroup: fix to allow mounting a hierarchy by name

From: Tejun Heo
Date: Tue Dec 27 2011 - 11:36:01 EST


Hello, Li.

On Tue, Dec 27, 2011 at 10:10:37AM +0800, Li Zefan wrote:
> If we mount a hierarchy with a name specified, the name is unique,
> and we can use it to mount the hierarchy without specifying its
> set of subsystem names. This feature is documented is
> Documentation/cgroups/cgroups.txt section 2.3
>
> Here's an example:
>
> # mount -t cgroup -o cpuset,name=myhier xxx /cgroup1
> # mount -t cgroup -o name=myhier xxx /cgroup2
>
> But it was broken by commit 32a8cf235e2f192eb002755076994525cdbaa35a
> (cgroup: make the mount options parsing more accurate)
>
> This fixes the regression.

Hmmm... so that has been broken over a year and nobody complained? Is
there any valid use case where specifying mount path as all other
filesystems wouldn't work? Is this 'name' thing necessary at all?
Maybe we should rip it out instead of fixing it? We can just leave it
as non-functional name which does nothing but being visible in mount
listing.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/