Re: [Fwd: [patch] intel_idle: Delete meaninglesslocal_irq_disable() call in intel_idle.c.]
From: Yanmin Zhang
Date: Tue Dec 27 2011 - 19:27:52 EST
On Tue, 2011-12-27 at 16:10 -0800, Andrew Morton wrote:
> On Mon, 26 Dec 2011 09:28:20 +0800
> Yanmin Zhang <yanmin_zhang@xxxxxxxxxxxxxxx> wrote:
> > Andrew,
> > Would you like to accept the patch into your testing tree?
> hm, that's three indel_idle patches which I have now. Someone wake up
> > intel_idle.c is a bit misleading in a sense that local_irq_disable,it
> I'd suggest adding this as well:
Agree. It'll be clearer.
> --- a/drivers/idle/intel_idle.c~drivers-idle-intel_idlec-remove-redundant-local_irq_disable-call-fix
> +++ a/drivers/idle/intel_idle.c
> @@ -232,6 +232,7 @@ static int get_driver_data(int cstate)
> * @drv: cpuidle driver
> * @index: index of cpuidle state
> + * Must be called under local_irq_disable().
> static int intel_idle(struct cpuidle_device *dev,
> struct cpuidle_driver *drv, int index)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/