Re: [PATCH] cgroup: fix to allow mounting a hierarchy by name
From: Tejun Heo
Date: Thu Dec 29 2011 - 11:23:20 EST
On Thu, Dec 29, 2011 at 10:50:06AM +0800, Li Zefan wrote:
> Tejun Heo wrote:
> > Hello, Li.
> > On Wed, Dec 28, 2011 at 02:10:42PM +0800, Li Zefan wrote:
> >> The "name" option was introduced along with the "none" option, so we
> >> can distinguish between different cgroup hierarchies which have no
> >> bound subsystems, like this:
> >> # mount -t cgroup -o none,name=hier1 xxx /cgroup1
> >> # mount -t cgroup -o none,name=hier2 xxx /cgroup2
> >> As the name is unique, we have this "mount by hierarchy name" feature.
> > I could be missing something but does that add anything other than
> > naming convenience?
> The name option is necessary, otherwise how can we mount hierarchies
> as shown in the above example?
I don't think mounting itself would be a problem. We don't need name
option to create multiple tmpfs instances, right? The problem is
referencing to them after they're created. Filesystems generally
don't need such identifier because, once they're created, they can be
referenced by their mount points. I'm still not very familiar with
different corners of cgroup, so it's entirely possible that I'm
missing something. If I am, please point me to it.
> > If it's a redundant feature which has been broken over a year without
> > anyone complaining, it really doesn't need to exist. It might not
> > save a lot of code but would save some WTH moments.
> The redundant feature is mouting existing hierarchies by specifying name
> only, and the cleanup patch I sent has this feature removed in effect.
> kernel/cgroup.c | 15 +++++++--------
> 1 files changed, 7 insertions(+), 8 deletions(-)
> This is why I'm not so keen to remove the feature.
Code reduction is definitely a plus and I don't want to remove a
useful feature either, but an unusual redundant feature without
necessity is confusing / misleading even if it doesn't necessasrily
add a lot of code complexity.
Also, I at least want to understand why it's actually necessary before
applying the patches. :)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/