Re: [PATCH resend] rtc: Fix alarm rollover when day or month isout-of-range

From: Alessandro Zummo
Date: Mon Jan 02 2012 - 08:49:22 EST


On Fri, 30 Dec 2011 18:35:52 -0600
Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:

> From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Date: Thu, 29 Dec 2011 16:41:56 +0100
>
> Commit f44f7f96a20a ('RTC: Initialize kernel state from RTC')
> introduced a potential infinite loop. If an alarm time contains a
> wildcard month and an invalid day (> 31), or a wildcard year and an
> invalid month (>= 12), the loop searching for the next matching date
> will never terminate. Treat the invalid values as wildcards.
>
> Fixes <http://bugs.debian.org/646429>, <http://bugs.debian.org/653331>
>
> Reported-by: leo weppelman <leoweppelman@xxxxxxxxxxxxxx>
> Reported-by: "P. van Gaans" <mailme667@xxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>


Seems reasonable, ty.


Acked-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>

--

Best regards,

Alessandro Zummo,
Tower Technologies - Torino, Italy

http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/