Re: [PATCH -next] debugfs: add missing #ifdef HAS_IOMEM

From: Al Viro
Date: Tue Jan 03 2012 - 19:48:29 EST


On Tue, Jan 03, 2012 at 04:44:52PM -0800, Greg KH wrote:
> On Tue, Dec 27, 2011 at 03:08:28PM +0100, Heiko Carstens wrote:
> > "debugfs: add tools to printk 32-bit registers" adds new functions which rely
> > on IOMEM functionality which is not present on all architectures and therefore
> > result in compile errors:
> >
> > fs/debugfs/file.c: In function 'debugfs_print_regs32':
> > fs/debugfs/file.c:561:7: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
>
> Who does not have readl()? Surely there should be a .h file we are just
> missing to include?

s390, uml, etc. What the hell is that kind of stuff doing in fs/*/*, anyway?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/