Re: [RFC PATCH v1 1/2] virtio_net: Pass gfp flags when allocating rx buffers.

From: Rusty Russell
Date: Wed Jan 04 2012 - 20:35:36 EST


On Wed, 04 Jan 2012 14:52:32 -0800, Mike Waychison <mikew@xxxxxxxxxx> wrote:
> Currently, the refill path for RX buffers will always allocate the
> buffers as GFP_ATOMIC, even if we are in process context. This will
> fail to apply memory pressure as the worker thread will not contribute
> to the freeing of memory.
>
> Fix this by changing add_recvbuf_small to use the gfp variant allocator,
> __netdev_alloc_skb_ip_align().
>
> Signed-off-by: Mike Waychison <mikew@xxxxxxxxxx>

OK, this is a no-brainer. Thanks! Dave, can you pick this up?

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/