Re: [PATCH 1/1] kmemleak/module: only scan the existed data section

[tiejun.chen]

Tiejun Chen wrote:
> We should only scan the sections containing data and it's size is not
> zero as well.

Catalin,

Could you take a look at this?

Thanks
Tiejun

> 
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxxxxxx>
> ---
>  kernel/module.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 12cfa2b..0b93c30 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2045,6 +2045,8 @@ static void kmemleak_load_module(struct module *mod, Elf_Ehdr *hdr,
>  		if (strncmp(secstrings + sechdrs[i].sh_name, ".data", 5) != 0
>  		    && strncmp(secstrings + sechdrs[i].sh_name, ".bss", 4) != 0)
>  			continue;
> +		if (sechdrs[i].sh_size == 0)
> +			continue;
>  
>  		kmemleak_scan_area((void *)sechdrs[i].sh_addr,
>  				   sechdrs[i].sh_size, GFP_KERNEL);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/