Re: [PATCH v4] regulator: Add S5M8767A regulator driver

[Mark Brown]

On Mon, Jan 09, 2012 at 05:35:47PM +0900, Sangbeom Kim wrote:

> After delete above functions, Is it right to code like below?

> +static struct regulator_ops s5m8767_buck_ops = {
> +	.enable	 = s5m8767_reg_enable,
> +	.disable	 = s5m8767_reg_disable,
> +	.set_suspend_enable	= s5m8767_reg_enable,
> +	.set_suspend_disable	= s5m8767_reg_disable,

No.  If your hardware doesn't have this feature your driver shouldn't
pretend it does, and if such a mapping were a good way of implementing
this we'd be better doing it in the core.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/